On Tue, 6 Feb 2024 10:31:06 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this doc-only change which updates the javadoc >> of several classes in `java.util.jar` and `java.util.zip` to specify their >> behaviour when `null` arguments are passed to the constructor or methods of >> those classes? >> >> For these updated classes, I have individually checked that they indeed >> throw a `NullPointerException` when `null` is passed to their constructor or >> methods. The couple of places where `null` is accepted have been updated to >> mention that `null` is allowed. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > include CheckedInputStream and CheckedOutputStream Hi Jai, Thank you for tackling this. An initial comment on a quick read I noticed you use "can cause" here and later use "will cause". I think we should try to be consistent. Perhaps we should use "will result in a..." ------------- PR Review: https://git.openjdk.org/jdk/pull/17728#pullrequestreview-1864907969
