On Wed, 7 Feb 2024 09:41:40 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   make <p> usage consistent with other similar usages in the file
>
> src/java.base/share/classes/java/util/zip/DeflaterInputStream.java line 80:
> 
>> 78:         // "in" being null isn't allowed. we use a null check for "in"
>> 79:         // merely to avoid an unnecessary instance creation of the 
>> Deflater
>> 80:         // for such erroneous cases.
> 
> I see this same comment has been added in 3 places but it's not easy to read 
> and I don't think is needed.

I've now updated the PR to remove this code comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17728#discussion_r1481231121

Reply via email to