On Sun, 12 May 2024 09:48:42 GMT, xiaotaonan <d...@openjdk.org> wrote:
>> Add API to access ZipEntry.extraAttributes > >> /csr > @AlanBateman > > This issue was reported by a person named Alan Snyder, I don't have his or > her contact information, how to create a CSR in this situation. @xiaotaonan Since you appear confused, "discussion on core libs" means discussion on core-libs-dev@openjdk.org mailing list https://mail.openjdk.org/mailman/listinfo/core-libs-dev where we can agree on what is a safe and future-proof way to expose the extraAttributes. The csr command is just routinely issued for any patch that changes the Java APIs to protect against accidentally changing the public API. You shouldn't submit your CSR until you are sure the API surface (including method signatures + API Documentation/Javadoc) are settled down. If anything changes, you must re-draft your CSR to go through the CSR review process again. Also, if you want to update a pull request, you can just push more commits; you don't have to force-push or delete your branch. When a pull request is integrated, openjdk bot will automatically squash and rename the squashed commit to your bug title, so please don't spam pull requests whenever you push a code update. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19204#issuecomment-2106237028
