On Wed, 5 Jun 2024 14:53:09 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>>  line 44:
>> 
>>> 42: resource.installdirnotemptydlg-wix-file=Not empty install directory 
>>> dialog WiX project file
>>> 43: resource.launcher-as-service-wix-file=Service installer WiX project file
>>> 44: resource.wix-src-conv=XSLT stylesheet converting WiX sources from WiX 
>>> v3 to WiX v4 format
>> 
>> WiX v4 -> WiX v4/v5
>
> The converter does exactly as described, it converts WiX v3 sources into WiX 
> v4 **format** that can be used with WiX v4 and WiX v5. So I believe the 
> description should remain unchanged.

Makes sense, but for `error.no-wix-tools` I think we should add v5, in case if 
users sees this message when only v5 is installed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19318#discussion_r1628308316

Reply via email to