On Thu, 20 Jun 2024 11:42:04 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

>> src/jdk.jdeps/share/man/jnativescan.1 line 127:
>> 
>>> 125: This option should be set to the version of the runtime under which the
>>> 126: application is eventually intended to be run.
>>> 127: If this flag is omitted, the version of \f[V]jnativescan\f[R] is used 
>>> as
>> 
>> Maybe we should point to `Runtime.version()` instead?
>
> Not sure. If a client is just using the tool, how would they know what 
> `Runtime.version()` returns? I mean, it's the version of the JDK, but to find 
> that out they'd have to use another JDK tool (e.g. jshell)  to print it out, 
> or look at the release file. The `jnativescan` version on the other hand is 
> readily accessible through the `--version` flag.

I'll add a note like: `, which is the same as the version of
the JDK that the tool belongs to.`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19774#discussion_r1647442344

Reply via email to