On Thu, 20 Jun 2024 09:56:45 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Please review this fix for an intermittent test failure. >> >> On some configurations, the default `expect` timeout of 10 seconds is >> insufficient. It is increased to 20; it's hard to imagine a configuration >> for which that new value would still be insufficient, but we'll see. >> >> Aside from that, test-generated diagnostics are improved: the version of the >> `expect` command and the duration of each test method are recorded. >> `output.exp` is modified for robustness and clear indication of the timeout >> condition. >> >> I was reminded, out-of-band, that test timeouts should be scaled with >> `test.timeout.factor`. I propose to integrate this PR first and then >> separately update all the affected tests to scale their `expect` timeouts. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Merge branch 'master' into 8333358 > - Merge branch 'master' into 8333358 > - Add a comment for future maintainers > - Disable timeout in expect scripts > - Change url as suggested in review > - Initial commit Marked as reviewed by naoto (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19627#pullrequestreview-2130880264
