On Thu, 13 Jun 2024 06:29:36 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Disable timeout in expect scripts > > test/jdk/java/io/IO/IO.java line 192: > >> 190: // adapted from >> https://junit.org/junit5/docs/current/user-guide/#extensions-lifecycle-callbacks-timing-extension >> 191: >> 192: public static class TimingExtension implements >> BeforeTestExecutionCallback, > > In passing, this feels like infrastructure that we could use in several areas > as it regularly comes up as to how long specific tests take (the "seconds" > line recorded by jtreg in the .jtr file is too coarse grain when there are > many tests in the same source file). Looking briefly at this, I think we should be able to provide this as a feature of jtreg's support of `junit` test itself. I've created https://bugs.openjdk.org/browse/CODETOOLS-7903751 to investigate this support in jtreg. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19627#discussion_r1637663845
