On Thu, 27 Jun 2024 10:27:03 GMT, Aleksei Efimov <[email protected]> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - use javadoc standards
>> - Merge remote-tracking branch 'upstream/master' into naming
>> - remove whitespace
>> - 8332072: Convert package.html files in `java.naming` to package-info.java
>
> src/java.naming/share/classes/javax/naming/ldap/spi/package-info.java line 29:
>
>> 27: *
>> 28: * Extends the {@code javax.naming.ldap} package to provide the classes
>> 29: * and interfaces for the Service Provider Interface (SPI) for LDAP
>
> The `javax.naming.ldap.spi` package only contains SPI classes that can
> customize DNS lookups when performing LDAP operations. It was added by
> [JDK-8160768](https://bugs.openjdk.org/browse/JDK-8160768)/[CSR](https://bugs.openjdk.org/browse/JDK-8192975).
>
> Since the package only contains classes related to this SPI maybe we could
> change the wording to something like this:
> Suggestion:
>
> * Provides the Service Provider Interface for DNS lookups when
> * performing LDAP operations.
Thanks, Fixed in
[0104e4a](https://github.com/openjdk/jdk/pull/19529/commits/0104e4ac5a9bfe143822e72756771c29e0f32731)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19529#discussion_r1658495820
