On Mon, 7 Jul 2025 09:54:28 GMT, Per Minborg <pminb...@openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Test to verify observed internal unsafe behaviors
>
> src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
>  line 405:
> 
>> 403:                 throw new IllegalArgumentException("Must be volatile 
>> type");
>> 404: 
>> 405:             if (Modifier.isStatic(modifiers))
> 
> Can we break out the Modifier tests in the three updater classes to a common 
> method?

Should we include that in this patch?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25945#discussion_r2189863484

Reply via email to