On Thu, 13 Nov 2025 02:31:31 GMT, SendaoYan <[email protected]> wrote:

> Hi all,
> 
> In JDK 11, ThreadPoolExecutor.finalize() was specified to do nothing, leaving 
> the finalize() method empty by 
> [JDK-8371748](https://bugs.openjdk.org/browse/JDK-8371748), so I think it's 
> safety to remove finalize() in testFinalizeMethodCallsSuperFinalize for 
> test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java.
> 
> This PR also remove unnecessary '@SuppressWarnings("removal")' in 
> test/jdk/java/util/concurrent/tck/JSR166TestCase.java and 
> test/jdk/java/util/concurrent/tck/ExecutorsTest.java.
> 
> Change has been verified locally on linux-x64 by run test 
> ava/util/concurrent/tck/JSR166TestCase.java#default. Test-fix only, no risk,

What does `testFinalizeMethodCallsSuperFinalize` test now?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28278#issuecomment-3526053688

Reply via email to