> Hi all,
> 
> In JDK 11, ThreadPoolExecutor.finalize() was specified to do nothing, leaving 
> the finalize() method empty by 
> [JDK-8371748](https://bugs.openjdk.org/browse/JDK-8371748), so I think it's 
> safety to remove finalize() in testFinalizeMethodCallsSuperFinalize for 
> test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java.
> 
> This PR also remove unnecessary '@SuppressWarnings("removal")' in 
> test/jdk/java/util/concurrent/tck/JSR166TestCase.java and 
> test/jdk/java/util/concurrent/tck/ExecutorsTest.java.
> 
> Change has been verified locally on linux-x64 by run test 
> java/util/concurrent/tck/JSR166TestCase.java#default. Test-fix only, no risk,

SendaoYan has updated the pull request incrementally with one additional commit 
since the last revision:

  Remove testFinalizeMethodCallsSuperFinalize

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28278/files
  - new: https://git.openjdk.org/jdk/pull/28278/files/374c8ef8..3c57f3bc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28278&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28278&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/28278.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28278/head:pull/28278

PR: https://git.openjdk.org/jdk/pull/28278

Reply via email to