On Mon, 17 Nov 2025 04:38:46 GMT, SendaoYan <[email protected]> wrote:
>> Hi all, >> >> In JDK 11, ThreadPoolExecutor.finalize() was specified to do nothing, >> leaving the finalize() method empty by >> [JDK-8371748](https://bugs.openjdk.org/browse/JDK-8371748), so I think it's >> safety to remove finalize() in testFinalizeMethodCallsSuperFinalize for >> test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java. >> >> This PR also remove unnecessary '@SuppressWarnings("removal")' in >> test/jdk/java/util/concurrent/tck/JSR166TestCase.java and >> test/jdk/java/util/concurrent/tck/ExecutorsTest.java. >> >> Change has been verified locally on linux-x64 by run test >> java/util/concurrent/tck/JSR166TestCase.java#default. Test-fix only, no risk, > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > Remove testFinalizeMethodCallsSuperFinalize Besides remove the testFinalizeMethodCallsSuperFinalize, this PR also remove two unnecessary '@SuppressWarnings("removal")'. So I think it's suitable integrate this PR standalone before https://github.com/openjdk/jdk/pull/28311. Thanks all for the reviews. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28278#issuecomment-3541921000
