On Sun, 1 Feb 2026 07:41:59 GMT, Jatin Bhateja <[email protected]> wrote:

>> As per [discussions 
>> ](https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594) on 
>> JDK-8370691 pull request, splitting out portion of PR#28002 into a separate 
>> patch in preparation of Float16 vector API support.
>> 
>> Patch add new lane type constants and pass them to vector intrinsic entry 
>> points.
>> 
>> All existing Vector API jtreg test are passing with the patch.
>> 
>> Kindly review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review comments resolution

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java 
line 580:

> 578:     public static ByteVector zero(VectorSpecies<Byte> species) {
> 579:         ByteSpecies vsp = (ByteSpecies) species;
> 580:         return VectorSupport.fromBitsCoerced(vsp.vectorType(), 
> vsp.laneTypeOrdinal(), species.length(),

You can now use `LANE_TYPE_ORDINAL` rather than `vsp.laneTypeOrdinal()`, which 
better fits the prior pattern.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29481#discussion_r2751629721

Reply via email to