On Tue, 3 Feb 2026 03:31:52 GMT, Jatin Bhateja <[email protected]> wrote:
>> As per [discussions >> ](https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594) on >> JDK-8370691 pull request, splitting out portion of PR#28002 into a separate >> patch in preparation of Float16 vector API support. >> >> Patch add new lane type constants and pass them to vector intrinsic entry >> points. >> >> All existing Vector API jtreg test are passing with the patch. >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin > > Jatin Bhateja has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments resolution src/hotspot/share/prims/vectorSupport.hpp line 141: > 139: > 140: // Values in this enum correspond to the jdk.incubator.vector.LaneType > ordinal values. > 141: enum LaneType { Please specify the underlying type of this enum: `enum LaneType : int`. Otherwise, this will not work: VectorSupport::LaneType vltype = static_cast<VectorSupport::LaneType>(laneType->get_con()); It is because casting an integer to an unscoped enum is UB if `laneType->get_con()` does not fit into the range of the enum values. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29481#discussion_r2765349355
