On Mon, 2 Feb 2026 09:07:21 GMT, Jatin Bhateja <[email protected]> wrote:

>> As per [discussions 
>> ](https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594) on 
>> JDK-8370691 pull request, splitting out portion of PR#28002 into a separate 
>> patch in preparation of Float16 vector API support.
>> 
>> Patch add new lane type constants and pass them to vector intrinsic entry 
>> points.
>> 
>> All existing Vector API jtreg test are passing with the patch.
>> 
>> Kindly review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review comment resolution

Very good. Approved, there is just one comment related to adding a comment for 
the LT_* values. Thank you for separating this out from the float16 PR. Needs a 
HotSpot reviewer too. We will run it through tier 1 to 3 testing.

src/hotspot/share/prims/vectorSupport.hpp line 140:

> 138:   };
> 139: 
> 140:   enum LaneType {

Please add a comment referencing `LaneType` and that the values in this enum 
correspond to the LaneType ordinal values.

-------------

Marked as reviewed by psandoz (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29481#pullrequestreview-3741431390
PR Review Comment: https://git.openjdk.org/jdk/pull/29481#discussion_r2755893774

Reply via email to