On Wed, 25 Feb 2026 02:14:33 GMT, Alexey Semenyuk <[email protected]> wrote:

> - Decouple jpackage implementation and test helpers from the current OS: 
> replace OperatingSystem.current() calls with parameters and/or fields of type 
> jdk.internal.util.OperatingSystem where feasible.
>  - Support running jpackage without making it run actual packaging. jpackage 
> will exit after it parses the command line, validates the options, and builds 
> a model.

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AppImageFile.java line 201:

> 199:         } else if (TKit.isWindows()) {
> 200:             return "windows";
> 201:         }  else if (TKit.isOSX()) {

Suggestion:

        } else if (TKit.isOSX()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29908#discussion_r2869784984

Reply via email to