On Tue, 3 Mar 2026 03:43:18 GMT, Alexey Semenyuk <[email protected]> wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java line 54:
>>
>>> 52: private Path relativePathInJavaHome() {
>>> 53: Path path = Path.of("bin", toolName());
>>> 54: if (OperatingSystem.isWindows()) {
>>
>> Should we use `TKit` for OS check in test code? Above you changed from
>> `OperatingSystem` to `TKit` and here is opposite.
>
> These changes are intentional. The path to a JDK tool is always specific to
> the real OS.
>
> In cases where TKit simulates execution on an OS that differs from the one
> returned by `OperatingSystem.current()`, the path to a JDK tool should still
> be valid on the real OS.
Makes sense. Do you know if we can introduce something like TKit.isRealWindows,
... or something to avoid confusion when to use what? I am ok keeping this way,
but I think it might be confusing why usage is different for someone who does
not now code well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29908#discussion_r2875926808
