On Tue, 3 Mar 2026 02:12:37 GMT, Alexander Matveev <[email protected]> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AppImageFile.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> > > src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgSystemEnvironment.java > line 46: > >> 44: List<? extends Exception> errors; >> 45: >> 46: if (OperatingSystem.isMacOS()) { > > Is there better design for this? Doing platform specific check in platform > specific code does not look right to me. Maybe created new class > `PlatformTools` in shared location and return tool path only for specific > platform or Optional.empty() for other platforms. I agree, it doesn't look great. At the momemt this is the only quirk of this kind. I suggest leaving this one as is, and if/when we get more, we implement it better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29908#discussion_r2875922094
