On Thu, 12 Mar 2026 05:14:21 GMT, Jaikiran Pai <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 253:
>>
>>> 251: public int hashCode() {
>>> 252: return imagePath.hashCode() ^
>>> Boolean.hashCode(previewMode);
>>> 253: }
>>
>> Given what the `ReaderKey` is, would making `ReaderKey` a `record` be
>> useful? That would also avoid having to explicitly implement the
>> equals/hashcode.
>
> Never mind, please ignore that comment. For a moment I forgot that this code
> needs to be compilable with Java 8.
JDK-8 only in this code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2924919279
