On Thu, 12 Mar 2026 05:17:54 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Updated copyright >> - Feedback changes > > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 270: > >> 268: >> 269: // Preview mode support. >> 270: private final boolean previewMode; > > Same comment here too, I think this should be `previewEnabled`. Done. > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 274: > >> 272: // preview-only nodes. This is used to add preview-only content >> to >> 273: // directories as they are completed. >> 274: private final HashMap<String, Directory> >> previewDirectoriesToMerge; > > The use of specific class types like `HashMap` and `ArrayList` for declaring > the type of a field/variable is not very common. Is there a reason we don't > use `Map<String, Directory>` and `List<Node>` here and some lines below? Fair. I think it was to emphasise that there's no ordering expected here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2924946271 PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2924955559
