On Wed, 25 Mar 2026 07:15:50 GMT, Jaikiran Pai <[email protected]> wrote:
> Hello Eirik, doing that change to ZipEntry in this PR (and CSR) is fine. One
> small typo in your new proposed text:
>
> > ...If {@code comment} is the empty string or {@code null}
>
> It should be "If {@code comment} is an empty string or {@code null}"
Hmm.. This was actually copied verbatim from `ZipOutputStream::setComment`.
I think what happened here was I initially started with "the empty string",
then Lance recommended "an empty string", then Alan suggested a text for the
method description which had "the empty string" again.
I have pushed the ZipEntry change and updated ZipOutputStream to use "an empty
string" as well. Alan will have a chance to flag this if "the empty string" was
deliberate.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/30338#issuecomment-4124356004
