On Tue, 24 Mar 2026 12:10:05 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Lift null and empty string note into the method description
>
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 146:
>
>> 144: * {@code null} then the output will have no ZIP file comment.
>> 145: *
>> 146: * @param comment the comment string, or an empty string or
>> null for no comment
>
> @AlanBateman To avoid the double "or", would something like the following
> work?
>
> "the comment string, may be empty or null for no comment"
I am wondering if we should add similar wordsmithing to ZipEntry::setComment
as part of this PR or in a separate PR
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2982804083
