On Mon, 30 Mar 2026 16:49:16 GMT, Chen Liang <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Be consistent with static imports
>
> test/jaxp/javax/xml/jaxp/unittest/sax/DefaultHandler2Test.java line 102:
>
>> 100: ParserAdapter adapter = new ParserAdapter(parser.getParser());
>> 101: assertThrows(SAXNotRecognizedException.class, () ->
>> adapter.getProperty("http://xml.org/sax/properties/declaration-handler";));
>> 102: assertThrows(SAXNotRecognizedException.class, () ->
>> adapter.setProperty("http://xml.org/sax/properties/declaration-handler";,
>> handler));
>
> Old code used new adapters, guess it's ok if this test passes.
I checked, and the called code is literally a method that unconditionally
throws.
> test/jaxp/javax/xml/jaxp/unittest/sax/NSSupportTest.java line 143:
>
>> 141: }
>> 142: }
>> 143: assertTrue(hasdcnew && hasdc1 && hasdc2);
>
> Ideally we would break these into multiple lines of assertTrue for easier
> debugging, but there are so many so let's just leave them be.
Yeah, even I draw the line somewhere.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30283#discussion_r3011861036
PR Review Comment: https://git.openjdk.org/jdk/pull/30283#discussion_r3011865096
