On Mon, 30 Mar 2026 21:16:19 GMT, David Beaumont <[email protected]> wrote:
>> Similar to other recent JAXP test migration PRs, but simpler in most cases. >> >> Edge cases include: >> * Lots of tests needing the PER_CLASS life-cycle due to having a base class >> with non-trivial test setup >> * Tests with incorrect expectations about thrown exceptions >> * Tests needlessly catching test framework exceptions when they should be >> left to fail normally > > David Beaumont has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The pull request contains one new > commit since the last revision: > > Remove redundant fail() calls and other feedback changes. > > * Remove redundant calls to fail() > * feedback While I agree with the desire to improve the tests, that would be a much bigger effort. I'd rather write error-prone style lints for these things and fix them everywhere at once. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30283#issuecomment-4161394973
