On Wed, 25 Mar 2026 19:14:11 GMT, Chen Liang <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Be consistent with static imports
>
> test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogSupportBase.java line 444:
>
>> 442: transformer.transform(xml, new StreamResult(out));
>> 443: debugPrint("out:\n" + out.toString());
>> 444: assertTrue(out.toString().contains(expected), "testXSLImport");
>
> Old message was not helpful (already included in stack trace, no debug print
> of expected) but we can leave it for now. Same below.
I made the message more useful.
> test/jaxp/javax/xml/jaxp/unittest/datatype/DurationTest.java line 126:
>
>> 124: Duration smallDur = factory.newDuration(10000);
>> 125: if (smallDur.subtract(bigDur).getSign() != -1) {
>> 126: fail("smallDur.subtract(bigDur).getSign() is not -1");
>
> These can be converted to `assertEquals` without message (already available
> from the default context) if you want to.
DurationTest is a bit of an issue and I've raised a separate bug for that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30283#discussion_r3011814148
PR Review Comment: https://git.openjdk.org/jdk/pull/30283#discussion_r3011823141
