On Thu, 9 Apr 2026 12:42:36 GMT, Chen Liang <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove comment referring to decoder() which is now inaccessible in the
>> subclass
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 248:
>
>> 246: if (asciiLen != len) {
>> 247: // Non-ASCII, fall back to decoding a String
>> 248: // We avoid using decoder() here since the UTF8ZipCoder is
>
> Dead comment
This comment was a bit mysterious to me even before this change, but I agreee
that mentioning decoder now is a dead end. I'll just remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3060242191
