On Tue, 14 Apr 2026 09:50:37 GMT, Eirik Bjørsnøs <[email protected]> wrote:

>> src/java.base/share/classes/java/util/zip/ZipCoder.java line 179:
>> 
>>> 177:                         .onMalformedInput(CodingErrorAction.REPORT)
>>> 178:                         
>>> .onUnmappableCharacter(CodingErrorAction.REPORT);
>>> 179:             }
>> 
>> We could use LazyConstant here (encoder as well), which can make the field 
>> final
>
> We could, but I'd prefer this PR to focus on the hierarchy switch, avoiding 
> general improvements unless they are trivial, obvious and add little review 
> noise. I have a follow-up PR planned which simplifies / aligns some ZipCoder 
> method implementations, this improvement could fit better there. 
> 
> Okay with you?

Yes, totally fine

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3081019274

Reply via email to