On Fri, 10 Apr 2026 12:02:58 GMT, Andrey Turbanov <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove comment referring to decoder() which is now inaccessible in the
>> subclass
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipCoder.java line 77:
>
>> 75: static class CharsetZipCoder extends ZipCoder {
>> 76:
>> 77: static CharsetZipCoder UTF8_INSTANCE = new
>> CharsetZipCoder(UTF_8);
>
> Shouldn't it be `final` ?
> Suggestion:
>
> static final CharsetZipCoder UTF8_INSTANCE = new
> CharsetZipCoder(UTF_8);
Fixed, thank you.
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipCoder.java line 124:
>
>> 122: }
>> 123:
>> 124: private Charset cs;
>
> make it final
> Suggestion:
>
> private final Charset cs;
Preexisting, but trivial. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3067806809
PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3067807250
