On Mon, 13 Apr 2026 21:27:32 GMT, Xueming Shen <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make fields 'UTF8_INSTANCE' and 'cs' fields final
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2009, 2025, Oracle and/or its affiliates. All rights
>> reserved.
>
> 2026?
Yes, thanks!
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 44:
>
>> 42: * Utility class for ZIP file entry name and comment decoding and
>> encoding.
>> 43: * <p>
>> 44: * The {@code ZipCoder} base class handles UTF-8, which is the the
>> common case
>
> "the the ..."
Fixed.
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 51:
>
>> 49: * the CharsetZipCoder subclass does hold decoder/encoder state and
>> therefore requires
>> 50: * external synchronization. Because of this, ZipCoder instances should
>> in general be
>> 51: * treated as is they are stateful.
>
> as IF they are stateful?
Thanks, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3078590690
PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3078591342
PR Review Comment: https://git.openjdk.org/jdk/pull/30640#discussion_r3078592202
