On Tue, 21 Apr 2026 12:54:53 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this test-only change which updates the > `test/jdk/tools/jar/JarExtractTest.java` test to use the jtreg scratch > directory for its temporary files? > > In addition to that change, the `testExtractNoDestDirWithPFlag` is a bit > different and that one intentionally expects to write out to a directory that > starts with a leading slash in its path. We use `/tmp` directory in that test > intentionally. In this PR, that test method now cleans up the `/tmp/` > directory after the test is done. > > I've looked through the discussions in the PR for JDK-8173970, where this > test was introduced and I've verified that this change doesn't impact any > original expectations of this test. I've also verified that the test > continues to pass with this change on all platforms in our CI. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/tools/jar/JarExtractTest.java line 289: > 287: try { > 288: // create a test specific directory in "/tmp" directory > 289: tempTestDir = Files.createTempDirectory(Path.of("/tmp"), > "8173970-").toAbsolutePath(); Can you remind us why the test is using /tmp? It is intentional because ... ? (BTW: the toAbsolutePath is not needed). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30847#discussion_r3118388219
