On Tue, 21 Apr 2026 15:02:13 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove toAbsolutePath() usage in test
>> - add code comments in test to explain why we use /tmp/ directory for
>> testExtractNoDestDirWithPFlag
>
> test/jdk/tools/jar/JarExtractTest.java line 289:
>
>> 287: try {
>> 288: // create a test specific directory in "/tmp" directory
>> 289: tempTestDir = Files.createTempDirectory(Path.of("/tmp"),
>> "8173970-").toAbsolutePath();
>
> Can you remind us why the test is using /tmp? It is intentional because ... ?
> (BTW: the toAbsolutePath is not needed).
Hello Alan, I've updated the test method to include some code comments
explaining what this test does and why the `/tmp/` directory path is in use.
Let me know if it clarifies this test method or if you suggest anything more.
> (BTW: the toAbsolutePath is not needed).
I've removed it from this test method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30847#discussion_r3118552227
