On Wed, 22 Apr 2026 09:38:15 GMT, Jaikiran Pai <[email protected]> wrote:

>> test/jdk/tools/jar/JarExtractTest.java line 302:
>> 
>>> 300:         } catch (IOException ioe) {
>>> 301:             Assumptions.abort("skipping test, since /tmp cannot be 
>>> written to: " + ioe);
>>> 302:             return;
>> 
>> This return sentence seems unreachable,
>
> The `Assumptions.abort(...)` does indeed throw an exception, but I prefer to 
> retain this `return` because I find it clearer when reading the code. If you 
> have a strong preference, let me know and I can remove it.

Retain the `return` is more clear when reading the code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30847#discussion_r3123291197

Reply via email to