On Tue, 28 Apr 2026 01:00:25 GMT, Alexander Matveev <[email protected]> wrote:
>> Provide finer control over the jpackage console output. >> >> Add an optional value to the `--verbose` option. The description of the >> option has changed from: >> >> --verbose >> Enables verbose output >> >> to >> >> --verbose [<[-]category(,[-]category)*>] >> Configures verbose output. Where "category" is one of >> "all" >> "console" >> "log" >> "errors" >> "progress" >> "resources" >> "summary" >> "tools" >> "trace" >> "warnings" >> >> Suppress all console output, enable logging via System.Logger API: >> --verbose log >> Enable all message categories in the console: >> --verbose console >> Enable all message categories, but "trace" and "tools" in the >> console: >> --verbose console,-trace,-tools >> Enable "trace" and "tools" message categories in the console: >> --verbose trace,tools >> Enable "trace" and "tools" message categories in the console and >> enable logging via System.Logger API: >> --verbose log,trace,tools >> >> If the option is specified without the value, it is equivalent to >> --verbose console,-trace >> If the option is not specified it is equivalent to >> --verbose errors,warnings >> >> >> Message categories explained in >> [JDK-8377120](https://bugs.openjdk.org/browse/JDK-8377120) CSR. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/AppImageSigner.java > line 150: > >> 148: try (var content = Files.list(frameworkPath)) { >> 149: content.forEach(toConsumer(path -> { >> 150: codesigners.codesignMacBundle().accept(path); > > Why this change? macOS Frameworks are not application bundles and our > `MacBundle.isValid()` will fail on Frameworks which means they will not be > signed. `codesignMacBundle()` is just a renamed `codesignDir()` that better fits its functionality. Are you suggesting that we never sign bundles in the "Frameworks" directory or that the structure of the bundles in the "Frameworks" directory is not recognized by the `MacBundle.fromPath()`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3157115128
