On Tue, 28 Apr 2026 21:09:33 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Provide finer control over the jpackage console output. >> >> Add an optional value to the `--verbose` option. The description of the >> option has changed from: >> >> --verbose >> Enables verbose output >> >> to >> >> --verbose [<[-]category(,[-]category)*>] >> Configures verbose output. Where "category" is one of >> "all" >> "console" >> "log" >> "errors" >> "progress" >> "resources" >> "summary" >> "tools" >> "trace" >> "warnings" >> >> Suppress all console output, enable logging via System.Logger API: >> --verbose log >> Enable all message categories in the console: >> --verbose console >> Enable all message categories, but "trace" and "tools" in the >> console: >> --verbose console,-trace,-tools >> Enable "trace" and "tools" message categories in the console: >> --verbose trace,tools >> Enable "trace" and "tools" message categories in the console and >> enable logging via System.Logger API: >> --verbose log,trace,tools >> >> If the option is specified without the value, it is equivalent to >> --verbose console,-trace >> If the option is not specified it is equivalent to >> --verbose errors,warnings >> >> >> Message categories explained in >> [JDK-8377120](https://bugs.openjdk.org/browse/JDK-8377120) CSR. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Fix review findings Looks good. Only several minor typo issues. Once fixed I will approve. src/jdk.jpackage/share/classes/jdk/jpackage/internal/cli/LogConfigParser.java line 58: > 56: var groupCategories = new BitSet(MessageCategory.values().length); > 57: var enableCategories = new > BitSet(MessageCategory.values().length); > 58: var diableCategories = new > BitSet(MessageCategory.values().length); `diableCategories` -> `disableCategories` src/jdk.jpackage/share/classes/jdk/jpackage/internal/log/LogEnvironment.java line 215: > 213: traits, > 214: sink -> { > 215: var printStacktrace = > traits.contains(ErrorLoggerTrait.PRINT_STACK_TRACE_ALWAYS); `printStacktrace` -> `printStackTrace` test/jdk/tools/jpackage/helpers/jdk/jpackage/test/stdmock/DebToolsMock.java line 59: > 57: > 58: public Builder withPackageLookup(boolean v) { > 59: if(v) { `if(v)` -> `if (v)` test/jdk/tools/jpackage/helpers/jdk/jpackage/test/stdmock/RpmToolsMock.java line 52: > 50: > 51: public Builder withPackageLookup(boolean v) { > 52: if(v) { `if(v)` -> `if (v)` test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/log/UtilsTest.java line 244: > 242: logger.foo(buf::append); > 243: assertTrue(buf.toString().isEmpty()); > 244: } while(false); `while(false)` -> `while (false)` test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/log/UtilsTest.java line 250: > 248: logger.foo(sb); > 249: assertTrue(sb.isEmpty()); > 250: } while(false); `while(false)` -> `while (false)` ------------- PR Review: https://git.openjdk.org/jdk/pull/29515#pullrequestreview-4209169321 PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3171401505 PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3171574173 PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3171745614 PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3171754797 PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3171807223 PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3171807442
