On Tue, 28 Apr 2026 20:53:01 GMT, Alexey Semenyuk <[email protected]> wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/AppImageSigner.java
>> line 150:
>>
>>> 148: try (var content = Files.list(frameworkPath)) {
>>> 149: content.forEach(toConsumer(path -> {
>>> 150: codesigners.codesignMacBundle().accept(path);
>>
>> Why this change? macOS Frameworks are not application bundles and our
>> `MacBundle.isValid()` will fail on Frameworks which means they will not be
>> signed.
>
> `codesignMacBundle()` is just a renamed `codesignDir()` that better fits its
> functionality.
>
> Are you suggesting that we never sign bundles in the "Frameworks" directory
> or that the structure of the bundles in the "Frameworks" directory is not
> recognized by the `MacBundle.fromPath()`?
Second one. That `MacBundle.fromPath()` will not recognize "Frameworks"
directory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29515#discussion_r3157235982
