On Thu, 30 Apr 2026 23:03:28 GMT, Chen Liang <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unnecessary throws
>
> src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java
> line 700:
>
>> 698: regionToSkeletonMap.getOrDefault(locale.getCountry(),
>> 699:
>> regionToSkeletonMap.getOrDefault(locale.getLanguage() + "-001",
>> 700: regionToSkeletonMap.getOrDefault("001", "h"))))
>> :
>
> Original code and the current code are performing 4 lookups even when one of
> the earlier lookup would produce a valid return value. Feels a bit painful :(
Seconded
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31006#discussion_r3173174845