On Fri, 1 May 2026 21:00:13 GMT, Justin Lu <[email protected]> wrote: >> Since input skeletons are not mandatory elements, theoretically it could be >> possible that CLDR data do not include it (very unlikely though). So instead >> of throwing an error here, defaulting to "h" at the calling site, even if >> the map is empty, would be desirable. > > Hmm, I was not talking about whether the CLDR data includes the input > skeletons, but the adapter itself. > > As I understand it, the old code only ever constructed`LocaleResources` from > a `ResourceBundleBasedAdapter` adapter. The new code introduces a fallback > for the case when the CLDR adapter is not a `ResourceBundleBasedAdapter`. I > am fine with it if it is intentional, I just noticed it differed from the > original semantics.
OK, now I got what you are saying. However, it is not possible that the CLDR adapter is not a ResourceBundleBasedAdapter, as `CLDRLocaleProviderAdapter` extends `JRELocaleProviderAdapter` which implements `ResourceBundleBasedAdapter`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31006#discussion_r3175227373
