On Fri, 1 May 2026 12:46:13 GMT, Viktor Klang <[email protected]> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Removed unnecessary throws
>
> test/jdk/sun/util/locale/provider/SkeletonRaceTest.java line 75:
> 
>> 73:         go.countDown();
>> 74:         pool.shutdown();
>> 75:         for (Future<?> f : futures) f.get();
> 
> Use try-with-resources on the pool (close waits for tasks to finish) so that 
> any exception thrown does not preclude the pool from cleaning up.
> 
> Another alternative is to use Virtual Threads instead, so that the cost of 
> creating 50 platform threads is mitigated, and instead run several passes to 
> attempt to provoke the race condition.

Modified the test case as suggested

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31006#discussion_r3175036317

Reply via email to