On Sat, 2 May 2026 16:16:30 GMT, Chen Liang <[email protected]> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Adding a comment
>
> src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java 
> line 713:
> 
>> 711:         }
>> 712: 
>> 713:         return hour;
> 
> I think the fallbacck "h" is incorrectly `null` here. You probably want to do 
> something like:
> 
> 
> if (...) {
>    for (..) {
>        var hour = regionToSkeletonMap.get(region);
>        if (hour != null) {
>            break;
>        }
>    }
> }
> 
> return "h";

Good catch! Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31006#discussion_r3182866703

Reply via email to