On Fri, 1 May 2026 22:36:56 GMT, Naoto Sato <[email protected]> wrote:
>> Fixing the race condition during the initialization of the skeleton map. The >> root cause was that the map could be accessed while it was still being >> initialized, leading to an NPE. Although the NPE could be avoided by >> returning a default value, the map initialization itself should be made >> thread safe. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Adding a comment src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java line 713: > 711: } > 712: > 713: return hour; I think the fallbacck "h" is incorrectly `null` here. You probably want to do something like: if (...) { for (..) { var hour = regionToSkeletonMap.get(region); if (hour != null) { break; } } } return "h"; ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31006#discussion_r3176889244
