On Fri, 5 Jun 2026 11:25:32 GMT, Marcono1234 <[email protected]> wrote:
>> Can I please get a review of this change which proposes to introduce a new >> jtreg test to cover the case where the underlying `InputStream` of a >> `GZIPInputStream` blocks? >> >> This test should help us catch any future regressions like the one reported >> recently in https://bugs.openjdk.org/browse/JDK-8377896. In fact, this test >> when run against a JDK version which has the changes from >> http://bugs.openjdk.org/browse/JDK-7036144, does indeed reproduce the >> JDK-8377896 issue. >> >> The test passes in the current mainline. >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/java/util/zip/GZIP/GZIPOverBlockingStreams.java line 69: > >> 67: private static final Random random = RandomFactory.getRandom(); >> 68: private static final String MEMBER_CONTENT_FORMAT = >> 69: "Hello member %d, greetings from Java " + >> System.getProperty("java.version") + "\n"; > > Out of curiosity, could including `System.getProperty("java.version")` risk > that the test becomes unstable between Java versions? > > Would it be better to obtain any 'random' data from the already existing > `random`? Hello @Marcono1234, the use of `java.version` value in that text is just for arbitrary text. That value doesn't get compared with any Java version. In any case, to avoid confusion, I'll remove that part from the text message. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31369#discussion_r3362695462
