On Tue, 16 Jun 2026 06:25:49 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/reflect/Field.java line 844: > >> 842: * <li>{@code D} is not a {@linkplain Class#isRecord() record >> class}.</li> >> 843: * <li>{@code D} is not a {@linkplain Class#isHidden() hidden >> class}.</li> >> 844: * <li>{@code D} is not a {@linkplain Class#isValue() value >> class}.</li> > > I think this new addition should explicitly state that it is applicable only > when preview features is enabled. Something like: > > > <li>Preview features is enabled and {@code D} is not a {@linkplain > Class#isValue() value class}.</li> Did you look at the generated javadoc? The generated javadoc will have the "PREVIEW" superscript after "value class" and would be interesting to see if that helps. (As it happens, I was discussed with Chen yesterday some further conditions that need to be listed here and whether they need additional clarification that they are a preview thing. The downside of more "Preview features is" or "When preview features are ..." is that it adds a lot of clutter to the list.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3418874020
