On Tue, 16 Jun 2026 07:33:42 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/reflect/Field.java line 1499: > >> 1497: * record class or hidden class), >> 1498: */ >> 1499: private boolean isFinalInstanceInNormalClass() { > > The implementation of this method hasn't been updated in this PR and thus it > now considers the final instance in a value class as belonging to a normal > class. Should this method's implementation (and its comment) be updated to > not consider value classes as normal? Core reflection is implemented on method handles so you won't see the changes in Field.java. For fields in value classes, the "field accessor" will be generated as read-only so the setter methods also throws. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3419069348
