On Tue, 16 Jun 2026 13:03:22 GMT, Erik Joelsson <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2822 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8386690: [lworld] cherry-pick JDK-8386124 Test >> serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does >> not match >> >> Reviewed-by: liach >> - 8385743: [lworld] investigate and address build related comments in the >> Valhalla PR >> >> Reviewed-by: liach, erikj >> - 8376346: [lworld] Basic Shenandoah support >> >> Reviewed-by: qamai >> - 8386598: [lworld] C1 acmp profiling fix and minor cleanup >> >> Reviewed-by: mchevalier >> - 8386618: [lworld] Remove unused entry_guard_Relocation >> >> Reviewed-by: chagedorn, jsjolen, jsikstro >> - Merge >> >> Merge jdk-28+2 >> - 8386623: [lworld] Cleanup module support for system modules in JDK >> exploded build with preview resources >> >> Reviewed-by: liach >> - 8386316: [lworld] Replace Valhalla since version with 28 >> >> Reviewed-by: darcy >> - ... and 2812 more: https://git.openjdk.org/jdk/compare/6def7d55...426cc065 > > make/CompileJavaModules.gmk line 159: > >> 157: FAIL_NO_SRC := $(FAIL_NO_SRC), \ >> 158: BIN := $(PREVIEW_OUTPUTDIR)/, \ >> 159: HEADERS := $(SUPPORT_OUTPUTDIR)/headers, \ > > As noted in https://bugs.openjdk.org/browse/JDK-8386458, just remove this > line and we are good. Doing this work with: [JDK-8386803](https://bugs.openjdk.org/browse/JDK-8386803) [lworld] remove HEADERS parameter from SetupJavaCompilation call for MODULE-PREVIEW_CLASSES_LABEL ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3424476720
