On Thu, 9 Jul 2026 05:23:58 GMT, Jatin Bhateja <[email protected]> wrote:
>> src/hotspot/cpu/x86/x86.ad line 14731: >> >>> 14729: match(Set dst (ConvF2L (ConvHF2F src))); >>> 14730: effect(TEMP dst, KILL cr, TEMP xtmp); >>> 14731: ins_cost(50); >> >> It looks to me that even without the ins_cost(50) and other ins_cost(200) >> changes, we will still get the direct HF conversion instruction selection. >> Better to remove the ins_cost related changes in this PR. > > If you permit, I would like to retain the static cost adjustments. They are > functionally harmless and act as a safeguard against cost-driven selection of > the component matcher rules, which this patch marks as high cost, during the > labeling phase. It is better to remove these cost adjustment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3552803533
