On Fri, 26 Jun 2026 07:49:59 GMT, Arno Zeller <[email protected]> wrote:
> --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Since this would be a behaviour change of `--strip-debug`, this will require a CSR. I can help review that. src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultStripDebugPlugin.java line 77: > 75: String pattern = debugFilePattern(in); > 76: ExcludeFilesPlugin excludeFilesPlugin = new ExcludeFilesPlugin(); > 77: excludeFilesPlugin.configure(Map.of(EXCLUDE_FILES_PLUGIN, > pattern)); This seems to suggest if `--strip-debug` *and* `--disable-plugin=exclude-files` are both present, the file exclusions would still happen I don't think that should be the case. This might need changes in `getPluginsConfig()` of `TaskHelper`. test/jdk/tools/jlink/plugins/DefaultStripDebugPluginTest.java line 1: > 1: /* There should be a new test ensuring that no files are excluded if the ExcludeFilesPlugin is disabled. ------------- PR Review: https://git.openjdk.org/jdk/pull/31690#pullrequestreview-4703940432 PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3587118461 PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3587166888
