Re: RFR: 8387324: jlink --strip-debug should filter external debug symbols [v2]

[Severin Gehwolf]

On Thu, 16 Jul 2026 08:23:06 GMT, Arno Zeller <azel...@openjdk.org> wrote:

>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Arno Zeller has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add check for --disable-plugin=exclude-files and disable file filtering in 
> this case.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java line 477:

> 475:             // disable the internal ExcludeFilesPlugin within 
> DefaultStripDebug plugin if
> 476:             // the exclude-files plugin was explicitly disabled via 
> --disable-plugin
> 477:             if (defaultStripDebugPlugin != null && 
> disabledPlugins.contains(EXCLUDE_FILES_NAME)) {

Do we really need the `disablePlugins` set?

Suggestion:

            if (defaultStripDebugPlugin != null && 
!seenPlugins.contains(EXCLUDE_FILES_NAME)) {

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultStripDebugPlugin.java
 line 90:

> 88:         if (!isExcludeFilesPluginEnabled) {
> 89:             return copyTo(result, out);
> 90:         }

Suggestion:

        if (!isExcludeFilesPluginEnabled) {
            result.transformAndCopy(Function.identity(), out);
            return out.build();
        }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3593990874
PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3593970640