On Thu, 16 Jul 2026 08:54:30 GMT, Severin Gehwolf <[email protected]> wrote:
>> Arno Zeller has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add check for --disable-plugin=exclude-files and disable file filtering in
>> this case.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java line 477:
>
>> 475: // disable the internal ExcludeFilesPlugin within
>> DefaultStripDebug plugin if
>> 476: // the exclude-files plugin was explicitly disabled via
>> --disable-plugin
>> 477: if (defaultStripDebugPlugin != null &&
>> disabledPlugins.contains(EXCLUDE_FILES_NAME)) {
>
> Do we really need the `disablePlugins` set?
>
> Suggestion:
>
> if (defaultStripDebugPlugin != null &&
> !seenPlugins.contains(EXCLUDE_FILES_NAME)) {
As far as I understand the `seenPlugins` will not contain exclude-files in case
it was disabled with **--disable-plugin**, because it was removed earlier from
the list or haven't been on the list by default.
And regarding user added filtering options I would guess, it is ok to keep the
debuginfo filtering in case someone added an **--exclude-files** option on the
commandline - do you agree?
> test/jdk/tools/jlink/plugins/DefaultStripDebugPluginTest.java line 1:
>
>> 1: /*
>
> There should be a new test ensuring that no files are excluded if the
> ExcludeFilesPlugin is disabled.
Add a test for this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3594663673
PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3594651235
