On Fri, 10 Jul 2026 12:52:29 GMT, Sholto <[email protected]> wrote: >> Sholto has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8272194: introduce faster code path for LocalDate/LocalDateTime conversion > > I did some benchmarking and the `GregorianCalendar` implementation is > noticeably slower. On my machine it was 29x slower. > I have implemented the faster codepath as suggested by @justin-curtis-lu as I > agree that it will speed up the conversion for an overwhelming majority of > use cases. > > We could potentially expand the number of dates covered by this faster > codepath by using a negative unix time representing a much earlier year. > However, I feel slightly uneasy by this as it is almost pushing towards > trying to check `getTime` directly to see if it is in BC time.
> Looks good to me too. Thank you @Sholto for fixing it! Excellent. I am just wondering, what is the next step of the process? ------------- PR Comment: https://git.openjdk.org/jdk/pull/31808#issuecomment-4991282385
