On Thu, 16 Jul 2026 11:27:14 GMT, Sholto <[email protected]> wrote:

>> I did some benchmarking and the `GregorianCalendar` implementation is 
>> noticeably slower. On my machine it was 29x slower.
>> I have implemented the faster codepath as suggested by @justin-curtis-lu as 
>> I agree that it will speed up the conversion for an overwhelming majority of 
>> use cases.
>> 
>> We could potentially expand the number of dates covered by this faster 
>> codepath by using a negative unix time representing a much earlier year.
>> However, I feel slightly uneasy by this as it is almost pushing towards 
>> trying to check `getTime` directly to see if it is in BC time.
>
>> Looks good to me too. Thank you @Sholto for fixing it!
> 
> Excellent. I am just wondering, what is the next step of the process?

Hi @Sholto, you can issue `/integrate` when ready, and one of us can sponsor 
this change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31808#issuecomment-5037187081

Reply via email to